Skip to content

Conversation

@Fuud
Copy link
Contributor

@Fuud Fuud commented Jan 19, 2026

Fix conformance tests.

  1. fix node version to workaround libuv assertion on Windows with Node.js 23.x nodejs/node#56645
  2. use @argfile to handle long classpaths
  3. specify extension for npx for windows
  4. Install @modelcontextprotocol/conformance@0.1.8 GitHub Actions workflow.
  5. Centralize logging for process streams in conformance tests: Add startLogging utility for InputStream logging with KotlinLogging. Replace inline process stream handling with startLogging calls

Note: Currently tests pass using @modelcontextprotocol/conformance@0.1.8/ But changing to 0.1.9 will fail client scenarios (it is not related to this PR).

Motivation and Context

Before fix conformance tests are broken on Windows

How Has This Been Tested?

Run test locally and in github actions

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

May be we should update CONTRIBUTING.md/Building/Requirements. But currently it does not mention at all: node, android, etc.

@kpavlov kpavlov added the tests label Jan 19, 2026
@kpavlov kpavlov force-pushed the fix-conformance-tests branch 2 times, most recently from 57003ec to dde8e93 Compare January 19, 2026 12:09
- Add matrix strategy to run conformance tests across Ubuntu, Windows, and macOS
@kpavlov kpavlov force-pushed the fix-conformance-tests branch from dde8e93 to 65ffd2c Compare January 19, 2026 12:37
…rmance tests

- Add `startLogging` utility for InputStream logging with `KotlinLogging`
- Replace inline process stream handling with `startLogging` calls
- Include `kotlin-logging` library for enhanced logging
- Update SLF4J properties for fine-grained logging control
@kpavlov kpavlov force-pushed the fix-conformance-tests branch 3 times, most recently from 769b278 to 1593571 Compare January 19, 2026 13:21
- Install `@modelcontextprotocol/conformance@0.1.8` GitHub Actions workflow.
@kpavlov kpavlov force-pushed the fix-conformance-tests branch from 1593571 to f41dbff Compare January 19, 2026 13:27
Copy link
Contributor

@kpavlov kpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Fuud

@kpavlov kpavlov merged commit c73507b into modelcontextprotocol:main Jan 19, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants