Skip to content

Add independent vertical scroll to Tools tab columns #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patriciomartinns wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −11
Open

Add independent vertical scroll to Tools tab columns #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions client/src/components/ListPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ const ListPane = <T extends object>({
};

return (
<div className="bg-card border border-border rounded-lg shadow">
<div className="p-4 border-b border-gray-200 dark:border-border">
<div className="bg-card border border-border rounded-lg shadow h-full flex flex-col overflow-hidden">
<div className="p-4 border-b border-gray-200 dark:border-border flex-shrink-0">
<div className="flex items-center justify-between gap-4">
<h3 className="font-semibold dark:text-white flex-shrink-0">
{title}
Expand Down Expand Up @@ -92,24 +92,24 @@ const ListPane = <T extends object>({
</div>
</div>
</div>
<div className="p-4">
<div className="p-4 flex flex-col flex-1 overflow-hidden">
<Button
variant="outline"
className="w-full mb-4"
className="w-full mb-4 flex-shrink-0"
onClick={listItems}
disabled={isButtonDisabled}
>
{buttonText}
</Button>
<Button
variant="outline"
className="w-full mb-4"
className="w-full mb-4 flex-shrink-0"
onClick={clearItems}
disabled={items.length === 0}
>
Clear
</Button>
<div className="space-y-2 overflow-y-auto max-h-96">
<div className="space-y-2 overflow-y-auto flex-1">
{filteredItems.map((item, index) => (
<div
key={index}
Expand Down
10 changes: 5 additions & 5 deletions client/src/components/ToolsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ const ToolsTab = ({
});

return (
<TabsContent value="tools">
<div className="grid grid-cols-2 gap-4">
<TabsContent value="tools" className="h-[calc(100vh-16rem)]">
<div className="grid grid-cols-2 gap-4 h-full">
<ListPane
items={tools}
listItems={listTools}
Expand Down Expand Up @@ -178,8 +178,8 @@ const ToolsTab = ({
isButtonDisabled={!nextCursor && tools.length > 0}
/>

<div className="bg-card border border-border rounded-lg shadow">
<div className="p-4 border-b border-gray-200 dark:border-border">
<div className="bg-card border border-border rounded-lg shadow h-full flex flex-col overflow-hidden">
<div className="p-4 border-b border-gray-200 dark:border-border flex-shrink-0">
<div className="flex items-center gap-2">
{selectedTool && (
<IconDisplay
Expand All @@ -192,7 +192,7 @@ const ToolsTab = ({
</h3>
</div>
</div>
<div className="p-4">
<div className="p-4 overflow-y-auto flex-1">
{selectedTool ? (
<div className="space-y-4">
{error && (
Expand Down