mcp: remove support for batching on streamable connections#948
Open
wucm667 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
mcp: remove support for batching on streamable connections#948wucm667 wants to merge 1 commit intomodelcontextprotocol:mainfrom
wucm667 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Batching was already deprecated and rejected for protocol versions >= 2025-06-18. Remove it entirely to simplify the streamable transport code. Replace readBatch calls with single message decoding, remove batch-related checks and comments, and delete batch-specific tests. Closes modelcontextprotocol#911 Signed-off-by: wucm667 <stevenwucongmin@gmail.com>
Contributor
|
Thanks for the contribution. We're still analyzing our backwards compatibility stance on this and when exactly we would like to remove it. I'll update you when this is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #911
Batching was already deprecated and rejected for protocol versions >= 2025-06-18.
Remove it entirely to simplify the streamable transport code.
Replaces
readBatchcalls with single message decoding, removes batch-relatedchecks and comments, and deletes batch-specific tests. No behavioral change for
single-message requests.