Skip to content

feat: deleted the old logger in client #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jba merged 1 commit into from
Jan 5, 2026
+2 −5
Merged

feat: deleted the old logger in client #744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions mcp/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ import (
// A Client is an MCP client, which may be connected to an MCP server
// using the [Client.Connect] method.
type Client struct {
impl *Implementation
opts ClientOptions
// Deprecated
logger *slog.Logger // TODO: file proposal to export this
impl *Implementation
opts ClientOptions
mu sync.Mutex
roots *featureSet[*Root]
sessions []*ClientSession
Expand Down Expand Up @@ -61,7 +59,6 @@ func NewClient(impl *Implementation, options *ClientOptions) *Client {
return &Client{
impl: impl,
opts: opts,
logger: ensureLogger(nil), // ensure we have a logger
roots: newFeatureSet(func(r *Root) string { return r.URI }),
sendingMethodHandler_: defaultSendingMethodHandler,
receivingMethodHandler_: defaultReceivingMethodHandler[*ClientSession],
Expand Down