docs: fix tsc command to use tsconfig.json #188
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove 'server.ts' argument from 'npx tsc --noEmit' command. When a file is specified directly, TypeScript ignores tsconfig.json, causing skipLibCheck and other options to not apply. This results in errors from node_modules (especially zod v4 locale files). The correct command lets tsc use the project's tsconfig.json settings.
liady
approved these changes
Dec 20, 2025
Collaborator
liady
left a comment
liady
left a comment
There was a problem hiding this comment.
Thanks @blackgirlbytes ! Great catch.
In case there'll be additional files the errors might be in them, though, so maybe we'd want to also tweak the line after that which refers to server.ts ?
Collaborator
|
Thanks @blackgirlbytes ! |
idosal
approved these changes
Dec 20, 2025
commit: |
Contributor
Author
Oh good point @liady . I can do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I went through the quickstart. Amazing job. I ran into one quick problem. The quickstart docs instruct users to run:
When a file is specified directly, TypeScript ignores tsconfig.json entirely, causing
skipLibCheckand other options to not apply. This results in a flood of errors fromnode_modules(especially zod v4 locale files).Solution
Remove the
server.tsargument:This lets tsc use the project's tsconfig.json settings, which includes
skipLibCheck: true.