Omit null mimeType from ResourceContents JSON serialization#1325
Merged
stephentoub merged 3 commits intomainfrom Feb 20, 2026
Merged
Omit null mimeType from ResourceContents JSON serialization#1325stephentoub merged 3 commits intomainfrom
stephentoub merged 3 commits intomainfrom
Conversation
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
stephentoub
approved these changes
Feb 20, 2026
Copilot
AI
changed the title
[WIP] Fix handling of null mimeType in JsonConverter
Omit null mimeType from ResourceContents JSON serialization
Feb 20, 2026
halter73
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResourceContents.Converter.Writeunconditionally wrote"mimeType": nullwhenMimeTypewas unset, violating the MCP schema where the property is optional.Changes
ResourceContents.cs: Guard themimeTypewrite with a null check, consistent with how_metais already handled in the same methodResourceContentsTests.cs: Add tests assertingmimeTypeis absent from serialized output whennull, for bothTextResourceContentsandBlobResourceContentsOriginal prompt
This pull request was created from Copilot chat.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.