Fix flaky DiagnosticTests on net10.0 by waiting for specific activities#1324
Merged
stephentoub merged 2 commits intomainfrom Feb 20, 2026
Merged
Fix flaky DiagnosticTests on net10.0 by waiting for specific activities#1324stephentoub merged 2 commits intomainfrom
stephentoub merged 2 commits intomainfrom
Conversation
…of counts The WaitForAsync conditions used activity count thresholds (>= 4) which could be satisfied by other server activities before the expected ones were exported, causing intermittent failures on net10.0. Changed to wait for the specific activities that the assertions need. Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate and fix CI failure for PR 1320
Fix flaky DiagnosticTests on net10.0 by waiting for specific activities
Feb 20, 2026
stephentoub
approved these changes
Feb 20, 2026
halter73
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiagnosticTests.Session_TracksActivitiesfails intermittently on net10.0 due to a race condition. Server messages are processed via fire-and-forget tasks, and theWaitForAsyncconditions used activity count thresholds (>= 4) that could be satisfied by other server activities before the expectedtools/callactivity was exported.WaitForAsyncconditions to wait for the specific activities the assertions require, rather than a server activity countThis failure also reproduces on
main— it is not caused by #1320.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.