Skip to content

Remove unnecessary _connectCts field from McpClientImpl #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Feb 20, 2026
+0 −5
Merged

Remove unnecessary _connectCts field from McpClientImpl #1323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42ddf3d
Initial plan
Copilot Feb 20, 2026
cc33312
Remove unnecessary _connectCts field from McpClientImpl
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/ModelContextProtocol.Core/Client/McpClientImpl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ internal sealed partial class McpClientImpl : McpClient
private readonly SemaphoreSlim _disposeLock = new(1, 1);
private readonly McpTaskCancellationTokenProvider? _taskCancellationTokenProvider;

private CancellationTokenSource? _connectCts;

private ServerCapabilities? _serverCapabilities;
private Implementation? _serverInfo;
private string? _serverInstructions;
Expand Down Expand Up @@ -526,9 +524,6 @@ private void RegisterTaskHandlers(RequestHandlers requestHandlers, IMcpTaskStore
/// </summary>
public async Task ConnectAsync(CancellationToken cancellationToken = default)
{
_connectCts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
cancellationToken = _connectCts.Token;

try
{
// We don't want the ConnectAsync token to cancel the message processing loop after we've successfully connected.
Expand Down
Loading