Remove dead code: options ??= new() in McpServerImpl constructor

[Copilot]

Throw.IfNull(options) already guarantees options is non-null before reaching the ??= assignment, making it unreachable dead code.

Change

• McpServerImpl.cs: Remove options ??= new(); and its trailing blank line from the constructor — the preceding null guard renders it impossible to execute.

Before:

Throw.IfNull(transport);
Throw.IfNull(options);

options ??= new();

_sessionTransport = transport;

After:

Throw.IfNull(transport);
Throw.IfNull(options);

_sessionTransport = transport;

Original prompt

In src/ModelContextProtocol.Core/Server/McpServerImpl.cs, line 61 contains:

options ??= new();

This is dead code. On line 59, Throw.IfNull(options) already validates that options is non-null and will throw an ArgumentNullException if it is null. Therefore, the null-coalescing assignment on line 61 can never execute its right-hand side — options is guaranteed to be non-null at that point.

Fix: Remove line 61 (options ??= new();) and the blank line following it (line 62) to keep formatting clean. The surrounding code (lines 58–63) currently looks like:

        Throw.IfNull(transport);
        Throw.IfNull(options);

        options ??= new();

        _sessionTransport = transport;

It should become:

        Throw.IfNull(transport);
        Throw.IfNull(options);

        _sessionTransport = transport;

This pull request was created from Copilot chat.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.