Skip to content

Add support for SGR 2 faint and SGR 9 strikethrough #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonme wants to merge 2 commits into
base: master
Choose a base branch
from
+26 −1
Open

Add support for SGR 2 faint and SGR 9 strikethrough #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
840bd19
Add support for SGR 2 faint and SGR 9 strikethrough
antonme Mar 28, 2026
5fe9053
Test SGR faint and strikethrough handling
antonme Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/terminal/terminalframebuffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,11 +489,17 @@ void Renditions::set_rendition( color_type num )
return;
}

bool value = num < 9;
bool value = num < 10;
switch ( num ) {
case 1:
set_attribute( bold, value );
break;
case 2:
set_attribute( faint, value );
break;
case 22:
set_attribute( bold, value );
set_attribute( faint, value );
break;
case 3:
case 23:
Expand All @@ -515,6 +521,10 @@ void Renditions::set_rendition( color_type num )
case 28:
set_attribute( invisible, value );
break;
case 9:
case 29:
set_attribute( strikethrough, value );
break;
default:
break; /* ignore unknown rendition */
}
Expand Down Expand Up @@ -546,6 +556,8 @@ std::string Renditions::sgr( void ) const
ret.append( "\033[0" );
if ( get_attribute( bold ) )
ret.append( ";1" );
if ( get_attribute( faint ) )
ret.append( ";2" );
if ( get_attribute( italic ) )
ret.append( ";3" );
if ( get_attribute( underlined ) )
Expand All @@ -556,6 +568,8 @@ std::string Renditions::sgr( void ) const
ret.append( ";7" );
if ( get_attribute( invisible ) )
ret.append( ";8" );
if ( get_attribute( strikethrough ) )
ret.append( ";9" );

if ( foreground_color ) {
// Since foreground_color is a 25-bit field, it is promoted to an int when
Expand Down
1 change: 1 addition & 0 deletions src/terminal/terminalframebuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ class Renditions
blink,
inverse,
invisible,
strikethrough,
SIZE
} attribute_type;

Expand Down
10 changes: 10 additions & 0 deletions src/tests/emulation-attributes.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@ baseline()
test_true_color
echo "Bold:"
test_true_color 1
echo "Bold, then normal intensity:"
test_true_color 1 22
echo "Faint:"
test_true_color 2
echo "Faint, then normal intensity:"
test_true_color 2 22
echo "Italic:"
test_true_color 3
echo "Underline:"
Expand All @@ -137,6 +143,10 @@ baseline()
test_true_color 7
echo "Invisible:"
test_true_color 8
echo "Strikethrough:"
test_true_color 9
echo "Strikethrough, then not crossed out:"
test_true_color 9 29
echo "Bold, italic and underline:"
test_true_color 1 3 4
;;
Expand Down