Skip to content

Conversation

@gmegidish
Copy link
Member

@gmegidish gmegidish commented Jan 27, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved shell command escaping on Android devices to properly handle space characters in command input.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Walkthrough

Modified the escapeShellText function in devices/android.go to include space characters in the set of shell-special characters requiring escape sequences. Spaces are now escaped with a backslash, changing the escaping behavior while preserving existing control flow and error handling.

Changes

Cohort / File(s) Summary
Shell Text Escaping
devices/android.go
Updated escapeShellText function to escape space characters by adding space to the shell-special character set
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing an issue where the Android io text command only sent the first word of text containing spaces. This aligns with the code change that now escapes space characters in shell text.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 7871788 into main Jan 27, 2026
15 checks passed
@gmegidish gmegidish deleted the fix-android-io-text-with-spaces branch January 27, 2026 16:08
@gmegidish gmegidish restored the fix-android-io-text-with-spaces branch January 27, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants