MAINT: Remove tomli, tomlsort, and ruff from test group#13809
MAINT: Remove tomli, tomlsort, and ruff from test group#13809larsoner wants to merge 3 commits intomne-tools:mainfrom
test group#13809Conversation
|
|
Won't they still be needed in the main env for IDE integrations to work? If only pre-commit installs them, they'll be in a separate env |
|
Oh I hadn't thought about IDEs... So maybe keep |
|
Yeah I'd say keep ruff. Personally I have toml-focused IDE integrations too, but I doubt most folks do |
|
Okay fixed! Ready for merge unless I should also make the |
might as well? |
|
Okay pushed, feel free to mark for merge-when-green if you're happy @drammock ! |
| "rpy2", | ||
| "scikit-learn >= 1.4", # released 2024-01-18, will become 1.5 on 2026-05-21 | ||
| "seaborn >= 0.5, != 0.11.2", | ||
| "selenium >= 4.27.1", |
There was a problem hiding this comment.
Maybe this one should move, too -- this is really only needed for making the contrib viz which only CircleCI does on a regular basis. But we can add stuff like this later if it becomes problematic (haven't heard many complaints about selenium installs so far)
|
Uggghh several failures in I'll try to fix here 😓 |
2 participants
tomli,toml-sort, andruffare installed bypre-commit install --install-hooksand are invoked usingpre-commitcalls nowadays. We shouldn't have them intestdeps, as they're not needed as--groupinstalls for standard testing / dev routines. Ifruffstill seems useful for devs, it could maybe be moved todevnottest(it's not needed for any of the tests we run on CIs or locally), but even this seems unnecessary in practice nowadays.Closes #13796