Skip to content

Conversation

@varunkasyap
Copy link
Contributor

@varunkasyap varunkasyap commented Dec 21, 2025

Reference issue (if any)

Fixes #13550.

What does this implement/fix?

Fixes a crash when reading Eyelink ASCII files whose first recording block contains no sample data. The reader now handles this edge case and includes a test.

Additional information

Test suite passed in my local
image

@varunkasyap varunkasyap marked this pull request as draft December 21, 2025 12:38
@varunkasyap varunkasyap force-pushed the fix-eyelink-empty-trial branch from edeccb6 to 2ab0800 Compare December 21, 2025 14:20
@varunkasyap
Copy link
Contributor Author

Hey, I couldn’t understand the reason for the failing checks. Can someone please explain?

@varunkasyap varunkasyap marked this pull request as ready for review December 21, 2025 14:51
@varunkasyap
Copy link
Contributor Author

Hey, just wanted to check why the welcome bot didn’t get triggered for my PR?

@scott-huberty
Copy link
Contributor

Thanks @varunkasyap ! I will take a look this week.

@scott-huberty
Copy link
Contributor

Hey @

Hey, I couldn’t understand the reason for the failing checks. Can someone please explain?

Short answer is that you need to create a CircleCI account. if you sign in to CircleCI with your GitHub account, then the CI will be able to confirm that there is a CircleCI account associated with your GitHub username, and the check should run.

in MNE-Python, we use Github Actions to run some of our CI's, and we use CircleCI to run some CI's. For security reasons, we prevent PRs from users who dont have CircleCI accounts from triggering CircleCI hosted tests.

@varunkasyap varunkasyap force-pushed the fix-eyelink-empty-trial branch from 521a72f to 0f1d846 Compare December 24, 2025 05:36
@varunkasyap
Copy link
Contributor Author

Short answer is that you need to create a CircleCI account. if you sign in to CircleCI with your GitHub account, then the CI will be able to confirm that there is a CircleCI account associated with your GitHub username, and the check should run.

Thanks @scott-huberty

I think this PR is now ready for review. Do I need to mention this change somewhere in the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

read_raw_eyelink() cannot handle empty first trial

2 participants