Skip to content

Delta changes #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
InTheParasol wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Delta changes #27

InTheParasol wants to merge 1 commit into from

Conversation

@InTheParasol
Copy link
Collaborator

@InTheParasol InTheParasol commented Apr 5, 2018 •
edited
Loading

  • Adding delta
  • Adding tests

@InTheParasol InTheParasol requested a review from mmitrik April 5, 2018 18:04
@InTheParasol InTheParasol self-assigned this Apr 5, 2018
mmitrik
mmitrik requested changes Apr 5, 2018
View reviewed changes
Copy link
Owner

@mmitrik mmitrik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall. But maybe fix the formatting while you're in there.

README.md
Alphabet
Bravo
Charlie
Delta
Copy link
Owner

@mmitrik mmitrik Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Owner

@mmitrik mmitrik Apr 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Check out www.bing.com.

testtest2
test

InTheParasol
InTheParasol commented Apr 5, 2018
View reviewed changes
Copy link
Collaborator Author

@InTheParasol InTheParasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did a good job here

README.md
This is my readMe
Alphabet
Bravo
Charlie
Copy link
Collaborator Author

@InTheParasol InTheParasol Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another

mmitrik
mmitrik previously approved these changes Apr 5, 2018
View reviewed changes
@mmitrik mmitrik dismissed their stale review April 5, 2018 18:16

Needs fixes

mmitrik
mmitrik requested changes Apr 5, 2018
View reviewed changes
Copy link
Owner

@mmitrik mmitrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do more work

@InTheParasol
Copy link
Collaborator Author

InTheParasol commented Apr 5, 2018

new comment

@InTheParasol InTheParasol changed the title Delta Delta changes Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmitrik mmitrik mmitrik requested changes

Assignees

@InTheParasol InTheParasol

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@InTheParasol @mmitrik