Add GitHub Action to request RFC reviews from maintainers#15
Open
B-Step62 wants to merge 1 commit into
Open
Conversation
Trigger on PRs that add a new RFC markdown file under rfcs/<slug>/ and post a comment tagging the core maintainers for review. Co-authored-by: Isaac
kramaranya
reviewed
May 11, 2026
| marker, | ||
| `Thanks for opening a new RFC! ${mentionList} — please take a look when you have a chance and leave your feedback.`, | ||
| "", | ||
| "Reviewers: see the [RFC process](../blob/main/README.md) for guidance on what to look for.", |
There was a problem hiding this comment.
I don't think we can use relative links in the comments
Suggested change
| "Reviewers: see the [RFC process](../blob/main/README.md) for guidance on what to look for.", | |
| "Reviewers: see the [RFC process](https://github.com/mlflow/rfcs/blob/main/README.md) for guidance on what to look for.", |
| const prNumber = context.payload.pull_request.number; | ||
| const author = context.payload.pull_request.user.login.toLowerCase(); | ||
|
|
||
| const maintainers = [ |
There was a problem hiding this comment.
Just a thought, have you considered creating a team in MLflow org that this workflow could tag or adding OWNERS file to the repo instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/request-rfc-review.yml, a GitHub Action that fires onpull_request_target(opened/ready_for_review) when files underrfcs/**change.rfcs/<slug>/<file>.md. Edits to existing RFCs are ignored.@dbczumar @daniellok-db @harupy @kriscon-db @mprahl @PattaraS @serena-ruan @TomeHirata @B-Step62) and asking for review. The PR author is excluded from the @mention list.Test plan
rfcs/NNNN-test/NNNN-test.mdand confirm the maintainer-tagging comment is posted exactly once.This pull request was AI-assisted by Isaac.