-
-
Notifications
You must be signed in to change notification settings - Fork 237
Prevent to always create a run #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
270b08a to
eb2986d
Compare
inimaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @benoit-cty! Maybe we can remove the call to self._create_run() in the __init__? I see that we create the run anyhow if not present in the add_emissions See here/
eb2986d to
199f1b4
Compare
Well, I think not having a run_id in I prefer the explicit way of not asking to add a run. |
inimaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @benoit-cty ! With this, the API client will be in better shape. I mentioned a minor comment
SaboniAmine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
199f1b4 to
23cb32f
Compare
The
ApiClientclass is creating a run in init. But when we are using it only to get data it create useless entry in the database.And now that the new API is in production, we could remove the warning.