Skip to content

Fix HDRS_LIST building when paths in header inclusion tree include spaces#3607

Open
lancelotblanchard wants to merge 1 commit into
ml-explore:mainfrom
lancelotblanchard:main
Open

Fix HDRS_LIST building when paths in header inclusion tree include spaces#3607
lancelotblanchard wants to merge 1 commit into
ml-explore:mainfrom
lancelotblanchard:main

Conversation

@lancelotblanchard
Copy link
Copy Markdown

Proposed changes

In mlx/backend/metal/make_compiled_preamble.sh, doing declare -a HDRS_LIST=($HDRS) breaks when the header inclusion tree $HDRS has paths with spaces. This manifests by headers not being properly linked, and a bunch of grep errors during build. This PR fixes header inclusion to support paths with spaces.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant