[CPU - Linux] AVX SIMD backend for fp16 and bf16 matmul#3502
Open
acsweet wants to merge 4 commits intoml-explore:mainfrom
Open
[CPU - Linux] AVX SIMD backend for fp16 and bf16 matmul#3502acsweet wants to merge 4 commits intoml-explore:mainfrom
acsweet wants to merge 4 commits intoml-explore:mainfrom
Conversation
Collaborator
|
@dhiltgen I remember ollama was doing something similar? Can you please check if this would live together with your work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds an AVX SIMD backend for fp16 and bf16 matmul (GEMM and GEMV) on CPU for Linux. Follows from the discussion in #2037, and is a precursor to adding the full set of AVX SIMD instructions in a follow-up PR. Let me know what you think, I'd appreciate any feedback (including adjustments to benchmarking methodology).
I modified the
bench_gemm.pyandbench_gemv.pyinbenchmarks/python/blasso they'd complete in a reasonable amount of time. I ran them with a build of mlx from this PR and against the official mlx release for comparison. Note I left out the other dtypes from the benchmarked results printed below due to potential build differences (could be an error on my part). I built mlx with:Bench setup
6.18.9-arch1-2 x86_64mlx-cpu==0.31.2torch==2.5.1+cpuBench results
GEMM - branch (this PR)
GEMM -
mlx-cpu==0.31.2GEMV - branch (this PR)
GEMV -
mlx-cpu==0.31.2Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes