Skip to content

Fix rope single token multiple sequences#3498

Open
angeloskath wants to merge 2 commits intomainfrom
fix-rope
Open

Fix rope single token multiple sequences#3498
angeloskath wants to merge 2 commits intomainfrom
fix-rope

Conversation

@angeloskath
Copy link
Copy Markdown
Member

Fixes #3494, #3496 .

Crazy that this was a bug for more than a year and nobody encountered it (nobody noticed)...

Copy link
Copy Markdown
Collaborator

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] mx.fast.rope produces wrong output for batch rows >= 1 when seq_len == 1

2 participants