async: Call set_channel_write_waker()#53
Merged
Merged
Conversation
This was a copy and paste bug calling set_channel_read_waker() instead. It could cause connections to get stuck, observed with rsync getting stuck at the first SSH packet buffer size (either ~700 bytes or 32768 bytes). The commit message for fix c843947 ("Wake write_waker instead of read_waker") said they wouldn't be noticed in sunsetc - it turns out that is wrong, if the write wake was the only pending event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a copy and paste bug calling set_channel_read_waker() instead. It could cause connections to get stuck, observed with rsync getting stuck at the first SSH packet buffer size (either ~700 bytes or 32768 bytes).
Kind of a follow up to #51, but was found coincidentally.