Fix exceptions when Traces and 3DFaces have 4 coordinates#3
Open
JosephEoff wants to merge 2 commits intomkernel:masterfrom
JosephEoff:master
Open
Fix exceptions when Traces and 3DFaces have 4 coordinates#3JosephEoff wants to merge 2 commits intomkernel:masterfrom JosephEoff:master
JosephEoff wants to merge 2 commits intomkernel:masterfrom
JosephEoff:master
Conversation
Owner
|
@JosephEoff thanks for pointing that out! I thought about it and came up with an alternative solution. I'm not entirely sure aboud SOLIDs though. Those are known to have 4 coordinates, right? Otherwise I'll update it's implementation to use the same fix. |
Author
|
Close. The for loop is a bit off. With it corrected, everything works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix exceptions when Traces and 3DFaces have 4 coordinates.
This is the same as the fix for SOLIDS with 4 coordinates.