Skip to content

fix: the run in run.py#1

Closed
orbisai0security wants to merge 1 commit into
mito753:mainfrom
orbisai0security:fix-v-002-url-validation-run-py
Closed

fix: the run in run.py#1
orbisai0security wants to merge 1 commit into
mito753:mainfrom
orbisai0security:fix-v-002-url-validation-run-py

Conversation

@orbisai0security
Copy link
Copy Markdown

Summary

Fix critical severity security issue in 2023/idekCTF_2022/Pwn_Sofire=good/distribution/remote/run.py.

Vulnerability

Field Value
ID V-002
Severity CRITICAL
Scanner multi_agent_ai
Rule V-002
File 2023/idekCTF_2022/Pwn_Sofire=good/distribution/remote/run.py:10

Description: The run.py script accepts a URL from user input, downloads the referenced executable without any integrity verification (no checksum, no cryptographic signature, no file type validation), and executes it via ./run.sh. There is no authentication on the service, no allowlist of trusted domains, and no sandboxing of the executed binary. Any party with access to the input prompt can supply a URL to a malicious binary and have it executed on the server with the privileges of the running process.

Changes

  • 2023/idekCTF_2022/Pwn_Sofire=good/distribution/remote/run.py

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix generated by OrbisAI Security
@mito753
Copy link
Copy Markdown
Owner

mito753 commented May 22, 2026

Thank you for the pull request.

This repository archives original CTF challenge files for educational and research purposes.
The affected run.py is part of the original CTF distribution and is intentionally kept close to the original challenge environment.

I agree that downloading and executing user-provided URLs would be unsafe in a production service.
However, this repository is not intended to run these files as a public service, and the top-level README already states that all examples should be executed only in isolated QEMU/CTF environments.

Also, this patch changes the original distribution behavior while only partially addressing the reported issue.
For these reasons, I will not merge this PR.

Thanks again for taking the time to report it.

@mito753 mito753 closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants