flake: inputs: remove flake-utils #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You don't need it. This commit supercedes <mitchellh#60>, which copies a function from `flake-utils`. Instead of using this (arguably bad) abstraction, introduce `eachSystem` and `pkgsFor`.
Author
|
This pull request is made in order to simplify the Ghostty flake, I'm running into some problems that require me to adjust their overlays, but a prerequisite to adopting a better pattern is the removal of |
Author
|
Could this PR please get some attention? I'm waiting for it to work on Ghostty's flake. |
|
@mitchellh can we get some review here? Would love to see this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You don't need it.
This pull-request supercedes #60, which copies a function from
flake-utils.Instead of using this (arguably bad) abstraction, introduce
eachSystemandpkgsFor.Also removed is some faulty recursion, replace
recwith recursion throughself, as is intended by the Flakes interface.I see that you use merge commits, and squash people's changes, so if you want me to make a separate pull-request for ee9cba5, just let me know. It is technically an independent change, and if you haven't seen the pattern before, might warrant some explanation.