Duplication of code #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i think there is no need for two remove functions we can do this with one remove function
simple comments added
minsuk-heo
reviewed
Jul 10, 2017
Owner
minsuk-heo
left a comment
minsuk-heo
left a comment
There was a problem hiding this comment.
hi, thanks for contribution, but
your change doesn't work if we remove first node in my linkedlist.
you can test removing 9 from your code.
Thanks.
Contributor
Author
|
good catch i t was late i forgot a section of code sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on the same cracking the code book and was looking at others that completed the same system your code is the awesome, great job, but I noticed on the removing items from a link list program thee is no need for two functions to remove the file we are doing the work twice.