Skip to content

Update tests, fix issues#228

Open
klauspost wants to merge 7 commits intominio:mainfrom
klauspost:update-tests-go126
Open

Update tests, fix issues#228
klauspost wants to merge 7 commits intominio:mainfrom
klauspost:update-tests-go126

Conversation

@klauspost
Copy link
Copy Markdown
Contributor

@klauspost klauspost commented Apr 6, 2026

  • Fix certificate reload on Windows (can corrupt heap)
  • Pin linter/fumpter in go.mod file
  • Disable windows+symlink tests
  • Move syscall dependent test to platform guarded file
  • Remove toolchain from go.mod - this is an SDK
  • Run tests on alternative platforms.
  • Don't use deprecated 'StringToUTF16Ptr'.
  • Add Go 1.26.x to tester.
  • Min version Go 1.25.x

We really should replace the notifier with something that is active. But not going down that road now.

* Fix certificate reload on Windows.
* Pin linter/fumpter in go.mod file
* Disable windows+symlink tests
* Move syscall dependent test to platform guarded file
* Remove toolchain from go.mod - this is an SDK
* Run tests on alternative platforms.
* Don't use deprecated 'StringToUTF16Ptr'.
* Add Go 1.26.x to tester.
* Min version Go 1.25.x
klauspost added a commit to klauspost/pkg that referenced this pull request Apr 6, 2026
Merge after minio#228 to include arm64 checks.

Before/after...

```
pkg: github.com/minio/pkg/v3/rng
cpu: AMD Ryzen 9 9950X 16-Core Processor
BenchmarkReader
BenchmarkReader/1000-32         	46546988	        25.88 ns/op	38635.30 MB/s	       0 B/op	       0 allocs/op
BenchmarkReader/1024-32         	70920727	        17.14 ns/op	59755.33 MB/s	       0 B/op	       0 allocs/op
BenchmarkReader/16384-32        	 5805674	       204.9 ns/op	79950.02 MB/s	       0 B/op	       0 allocs/op
BenchmarkReader/1048576-32      	   92539	     14080 ns/op	74470.24 MB/s	       0 B/op	       0 allocs/op

BenchmarkReader/1000-32         	52974752	        22.57 ns/op	44300.70 MB/s	       0 B/op	       0 allocs/op
BenchmarkReader/1024-32         	100000000	        11.37 ns/op	90096.95 MB/s	       0 B/op	       0 allocs/op
BenchmarkReader/16384-32        	14598060	        81.69 ns/op	200552.58 MB/s	       0 B/op	       0 allocs/op
BenchmarkReader/1048576-32      	  174301	      6384 ns/op	164256.53 MB/s	       0 B/op	       0 allocs/op
```

This comment was marked as resolved.

@klauspost klauspost requested a review from rraulinio April 7, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants