Skip to content

Conversation

@luigix25
Copy link

Package is already available in fedora: https://src.fedoraproject.org/rpms/igvm

Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
Copy link
Collaborator

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary packages are to be listed, not source packages. But it looks like this is primarily a library (igvm-libs), so if this will just be a dependency of another package (qemu-kvm?), then it may not need to be added explicitly.

While we're at it though, would igvm-tools also end up being shipped (and if so, where)?

@luigix25
Copy link
Author

Binary packages are to be listed, not source packages. But it looks like this is primarily a library (igvm-libs), so if this will just be a dependency of another package (qemu-kvm?), then it may not need to be added explicitly.

@yselkowitz yes it's a library, and yes it will be used by qemu-kvm.

While we're at it though, would igvm-tools also end up being shipped (and if so, where)?

mmh, what about replacing igvm with igvm-tools here?

@yselkowitz
Copy link
Collaborator

@luigix25 if all you are planning on doing is adding igvm(-libs) as a dependency of qemu-kvm, then you don't need this at all; it will get added automatically once the dependency is enabled in the build.

Only if igvm-tools is also worth shipping (and I have no idea if it is or not), then it should be added here.

@luigix25
Copy link
Author

@luigix25 if all you are planning on doing is adding igvm(-libs) as a dependency of qemu-kvm, then you don't need this at all; it will get added automatically once the dependency is enabled in the build.

Only if igvm-tools is also worth shipping (and I have no idea if it is or not), then it should be added here.

Alright, thanks for the info! Not sure if -tools is worth shipping. Closing this for now.

@luigix25 luigix25 closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants