-
Notifications
You must be signed in to change notification settings - Fork 6
MOBILEWEBVIEW-3: Add mindbox webview #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the WebView in-app message implementation by introducing a WebViewController abstraction layer to replace direct WebView usage. The changes improve maintainability by separating platform-specific WebView logic from the business logic and add support for reattaching in-app messages when restoring activity state.
Changes:
- Refactored
WebViewInAppViewHolderto useWebViewControllerinstead of directWebViewmanipulation - Introduced
WebViewJsBridgeinterface to replace the deletedWebAppInterfaceclass - Added reattachment support for in-app messages through new
reattachandcanReuseOnRestoremethods
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| WebViewInappViewHolder.kt | Refactored to use WebViewController abstraction, replacing direct WebView manipulation with controller methods, and added reattachment logic |
| WebAppInterface.kt | Deleted file - functionality moved to WebViewJsBridge interface |
| InAppViewHolder.kt | Added reattach and canReuseOnRestore interface methods with default implementations |
| AbstractInAppViewHolder.kt | Extracted common view attachment logic and implemented reattach method |
| InAppMessageViewDisplayerImpl.kt | Added logic to restore and reattach previously paused in-app holders |
| kmp-common-sdk | Updated subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
https://tracker.yandex.ru/MOBILEWEBVIEW-3