Support AddCollectionStructField interface#1883
Open
yhmo wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Adds client + request support for Milvus “AddCollectionStructField” (adding a struct/struct-array field to an existing collection), including schema (de)serialization updates and unit tests to validate the produced gRPC request.
Changes:
- Introduces
AddCollectionStructFieldReqrequest model and exposesMilvusClientV2#addCollectionStructField(...). - Implements
CollectionService#addCollectionStructField(...)and extendsSchemaUtilsstruct-field conversions to includenullableandtypeParams. - Adds/updates tests to verify request building and builder-class verification.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk-core/src/test/java/io/milvus/v2/service/collection/CollectionTest.java | Adds unit tests validating the gRPC request for adding a struct field and parameter validation behavior. |
| sdk-core/src/test/java/io/milvus/v2/client/MilvusClientV2Test.java | Extends builder/getter-setter verification to include the new request class. |
| sdk-core/src/test/java/io/milvus/v2/BaseTest.java | Mocks the new gRPC stub method for tests. |
| sdk-core/src/main/java/io/milvus/v2/utils/SchemaUtils.java | Adds nullable + typeParams support for struct field schema conversion to/from gRPC. |
| sdk-core/src/main/java/io/milvus/v2/service/collection/request/CreateCollectionReq.java | Extends struct field schema model with nullable + typeParams. |
| sdk-core/src/main/java/io/milvus/v2/service/collection/request/AddCollectionStructFieldReq.java | New request type for adding a struct field to an existing collection. |
| sdk-core/src/main/java/io/milvus/v2/service/collection/CollectionService.java | Implements the RPC call for addCollectionStructField. |
| sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java | Exposes the new public client method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: yhmo <yihua.mo@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.