GetPersistentSegmentInfo/GetQuerySegmentInfo enhancement#1876
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR enhances the v2 Utility APIs’ segment-info responses by exposing additional segment metadata (collection name and storage version) and updates unit/integration tests to validate the new fields.
Changes:
- Add
collectionNameandstorageVersiontoGetPersistentSegmentInfoResp.PersistentSegmentInfo. - Add
storageVersiontoGetQuerySegmentInfoResp.QuerySegmentInfo. - Update
UtilityServicemappings and expand tests to assert the new fields.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk-core/src/main/java/io/milvus/v2/service/utility/UtilityService.java | Populate newly added response fields (collectionName, storageVersion) from request/proto into v2 response models. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/response/GetPersistentSegmentInfoResp.java | Extend persistent segment info model with collectionName and storageVersion. |
| sdk-core/src/main/java/io/milvus/v2/service/utility/response/GetQuerySegmentInfoResp.java | Extend query segment info model with storageVersion. |
| sdk-core/src/test/java/io/milvus/v2/BaseTest.java | Mock gRPC responses for segment info APIs including storage version and sorting flags. |
| sdk-core/src/test/java/io/milvus/v2/service/utility/UtilityTest.java | Add unit tests asserting the new fields are present and correctly mapped. |
| sdk-core/src/test/java/io/milvus/v2/client/MilvusClientV2DockerTest.java | Add integration assertions for collectionName and storageVersion fields in segment info responses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: yhmo <yihua.mo@zilliz.com>
No description provided.