Skip to content

GetPersistentSegmentInfo/GetQuerySegmentInfo enhancement#1876

Merged
sre-ci-robot merged 1 commit into
milvus-io:masterfrom
yhmo:ma
May 29, 2026
Merged

GetPersistentSegmentInfo/GetQuerySegmentInfo enhancement#1876
sre-ci-robot merged 1 commit into
milvus-io:masterfrom
yhmo:ma

Conversation

@yhmo
Copy link
Copy Markdown
Contributor

@yhmo yhmo commented May 29, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 29, 2026 03:36
@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the v2 Utility APIs’ segment-info responses by exposing additional segment metadata (collection name and storage version) and updates unit/integration tests to validate the new fields.

Changes:

  • Add collectionName and storageVersion to GetPersistentSegmentInfoResp.PersistentSegmentInfo.
  • Add storageVersion to GetQuerySegmentInfoResp.QuerySegmentInfo.
  • Update UtilityService mappings and expand tests to assert the new fields.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk-core/src/main/java/io/milvus/v2/service/utility/UtilityService.java Populate newly added response fields (collectionName, storageVersion) from request/proto into v2 response models.
sdk-core/src/main/java/io/milvus/v2/service/utility/response/GetPersistentSegmentInfoResp.java Extend persistent segment info model with collectionName and storageVersion.
sdk-core/src/main/java/io/milvus/v2/service/utility/response/GetQuerySegmentInfoResp.java Extend query segment info model with storageVersion.
sdk-core/src/test/java/io/milvus/v2/BaseTest.java Mock gRPC responses for segment info APIs including storage version and sorting flags.
sdk-core/src/test/java/io/milvus/v2/service/utility/UtilityTest.java Add unit tests asserting the new fields are present and correctly mapped.
sdk-core/src/test/java/io/milvus/v2/client/MilvusClientV2DockerTest.java Add integration assertions for collectionName and storageVersion fields in segment info responses.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sdk-core/src/test/java/io/milvus/v2/client/MilvusClientV2DockerTest.java Outdated
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@mergify mergify Bot added ci-passed and removed ci-passed labels May 29, 2026
@yhmo yhmo added the lgtm label May 29, 2026
@sre-ci-robot sre-ci-robot merged commit 3e6cf42 into milvus-io:master May 29, 2026
6 checks passed
@yhmo yhmo deleted the ma branch May 29, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants