Improve Performance by Avoiding Recalculating Constants #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
convertRadiansToDegreesandconvertDegreesToRadiansmethods, we are creatingBigDecimals ofPI/180and180/PI. These values have high precision and BigDecimal is too slow. We move these into a static variable to avoid repeated creations.This change nets us about 50-66% speedup. The following table contains the testing on my machine.