-
Notifications
You must be signed in to change notification settings - Fork 1
✨ Transform to MTA pointer-based build repository #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
603cd18 to
1da3aa2
Compare
|
@djzager If possible, can you separate out deletions and the actual stuff into separate commits? |
This repository will no longer contain the source code for the MTA extensions. Instead, it will pull upstream konveyor/editor-extensions source code and apply MTA branding during the build process. The source code is removed to make way for the new pointer-based build system that references upstream by SHA.
This commit introduces a new build approach where we: - Reference upstream konveyor/editor-extensions by SHA - Pull upstream source at build time - Apply MTA branding via scripts during prebuild - Build extensions with MTA-specific configuration Key files: - mta-build.yaml: Configuration for upstream ref and branding - scripts/pull-upstream.js: Clones and prepares upstream workspace - scripts/apply-branding.js: Transforms package.json files for MTA - scripts/update-upstream.sh: Helper to update upstream SHA - .github/workflows/ci.yml: Build workflow using pointer-based approach This approach allows us to track upstream changes while maintaining MTA-specific branding and configuration without duplicating source.
1da3aa2 to
a4094cf
Compare
| "linux-arm64": "mta-analyzer-rpc", | ||
| "darwin-x64": "darwin-mta-analyzer-rpc", | ||
| "darwin-arm64": "darwin-mta-analyzer-rpc", | ||
| "win32-x64": "windows-mta-analyzer-rpc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need .exe here?
| path: .upstream-workspace/dist/*.vsix | ||
| retention-days: 30 | ||
|
|
||
| - name: Upload workspace for debugging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it make sense to upload artifacts all the time? I am wondering in a scenario where the build is successful but not quite right?
No description provided.