Add components for WC DataVis and DataVis NITRO#136
Add components for WC DataVis and DataVis NITRO#136tvenable-mie wants to merge 6 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds React wrapper components and Storybook examples for integrating the legacy wcdatavis grid and the newer datavis (DataVis NITRO) React grid into this UI library, including required dependency and Storybook configuration updates.
Changes:
- Introduce
WCDataViswrappers (WCDVSOURCE/WCDVGRID) andDataVisNITROwrappers (DataVisNitroSource/DataVisNitroGrid) with Storybook stories. - Add
wcdatavis/datavis(git) dependencies plus supporting assets (Font Awesome) and TypeScript module declarations forwcdatavis. - Update Storybook config and add sample JSON data for demos.
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/wcdatavis.d.ts | Adds minimal TS declarations for wcdatavis ESM entrypoints used by wrappers. |
| src/index.ts | Exposes the new DataVis components from the package root exports. |
| src/components/WCDataVis/WCDataVis.tsx | Implements React context + wrapper components around wcdatavis Source/View/Grid. |
| src/components/WCDataVis/WCDataVis.stories.tsx | Adds Storybook demos for wcdatavis wrapper usage. |
| src/components/WCDataVis/setup.ts | Sets global window.jQuery/$ required by wcdatavis plugins. |
| src/components/WCDataVis/index.ts | Public re-export surface for WCDataVis (currently mismatched vs implementation). |
| src/components/DataVisNITRO/DataVisNITRO.tsx | Implements datavis (NITRO) wrapper grid using DataGrid/TableRenderer over a wcdatavis view. |
| src/components/DataVisNITRO/index.ts | Public re-export surface for DataVis NITRO components/types. |
| src/components/DataVisNITRO/DataVisNITRO.stories.tsx | Adds Storybook demos for DataVis NITRO wrapper usage. |
| .storybook/public/sample-data.json | Adds sample dataset consumed by the new stories. |
| .storybook/preview-head.html | Adds Font Awesome CSS inclusion for wcdatavis icons (currently via /node_modules). |
| .storybook/main.ts | Tweaks Vite/esbuild JSX settings for Storybook. |
| package.json | Adds datavis, wcdatavis, and font-awesome dependencies. |
| pnpm-lock.yaml | Locks new dependencies and transitive deps for pnpm. |
| package-lock.json | Updates npm lockfile to reflect the dependency graph as well. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Deploying ui with
|
| Latest commit: |
18f2a05
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://efb176f1.ui-6d0.pages.dev |
| Branch Preview URL: | https://feature-datavis2.ui-6d0.pages.dev |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 16 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bb7fccc to
c4b1668
Compare
c4b1668 to
b42a27c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 16 changed files in this pull request and generated 8 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
b42a27c to
3eb265e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 16 changed files in this pull request and generated 5 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aa40c4a to
7c25e21
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 16 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bump DataVis & DataVis NITRO versions, fix type issues.
7c25e21 to
4719d66
Compare
6dc2580 to
5dff82d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated 7 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5dff82d to
200ca02
Compare
200ca02 to
503d274
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated 8 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
503d274 to
2dfb34e
Compare
2dfb34e to
814a580
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
I tried running this branch locally and wcdatavis runs perfectly after a pnpm install, but datavis nitro is throwing an error.
vite-app.js:31 SyntaxError: The requested module '/node_modules/.pnpm/numeral@2.0.6/node_modules/numeral/numeral.js?v=13e61733' does not provide an export named 'default' (at types.js:8:8)
Claudes 2 cents:
|
@garrity-miepub The dumb thing is, that same file is in DataVis NITRO and WC DataVis, and both run in Vite just fine, and the latter runs in Storybook just fine. But that's exactly the error I was dealing with all day yesterday. GPT 5.4 couldn't come up with a solution, and Opus 4.6 made all the changes in main.ts — after which it started working for me. I am suspicious that there are some caching causing troubles, because I have seen this a couple weeks ago and it resolved itself. I'll try a clean checkout and see if it works. |
|
GitHub Action build process is now encountering errors that I don't get on the command line in a clean checkout. |
dd6c865 to
b23cad3
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b23cad3 to
feff83f
Compare
feff83f to
18f2a05
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Turns out it was caused by |
Add new UI tags for WC DataVis and DataVis NITRO.
DataVis NITRO is a React + Tailwind + mieweb/ui frontend for DataVis ACE (acquisition + computation engine).
WC DataVis is a collection of interactive data exploration and visualization interfaces for DataVis ACE.
I created Storybook tags for NITRO like
<DataVisNitroSource>and<DataVisNitroGrid>.The WC DataVis tags are the same as layouts like
<WCDVSOURCE>and<WCDVGRID>.