Skip to content

Add components for WC DataVis and DataVis NITRO#136

Open
tvenable-mie wants to merge 6 commits intomainfrom
feature/datavis2
Open

Add components for WC DataVis and DataVis NITRO#136
tvenable-mie wants to merge 6 commits intomainfrom
feature/datavis2

Conversation

@tvenable-mie
Copy link
Contributor

@tvenable-mie tvenable-mie commented Mar 12, 2026

Add new UI tags for WC DataVis and DataVis NITRO.

DataVis NITRO is a React + Tailwind + mieweb/ui frontend for DataVis ACE (acquisition + computation engine).
WC DataVis is a collection of interactive data exploration and visualization interfaces for DataVis ACE.

I created Storybook tags for NITRO like <DataVisNitroSource> and <DataVisNitroGrid>.
The WC DataVis tags are the same as layouts like <WCDVSOURCE> and <WCDVGRID>.

CleanShot 20260312 at 145608 CleanShot 20260312 at 145602

Copilot AI review requested due to automatic review settings March 12, 2026 19:06
@tvenable-mie tvenable-mie marked this pull request as draft March 12, 2026 19:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds React wrapper components and Storybook examples for integrating the legacy wcdatavis grid and the newer datavis (DataVis NITRO) React grid into this UI library, including required dependency and Storybook configuration updates.

Changes:

  • Introduce WCDataVis wrappers (WCDVSOURCE/WCDVGRID) and DataVisNITRO wrappers (DataVisNitroSource/DataVisNitroGrid) with Storybook stories.
  • Add wcdatavis/datavis (git) dependencies plus supporting assets (Font Awesome) and TypeScript module declarations for wcdatavis.
  • Update Storybook config and add sample JSON data for demos.

Reviewed changes

Copilot reviewed 12 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/types/wcdatavis.d.ts Adds minimal TS declarations for wcdatavis ESM entrypoints used by wrappers.
src/index.ts Exposes the new DataVis components from the package root exports.
src/components/WCDataVis/WCDataVis.tsx Implements React context + wrapper components around wcdatavis Source/View/Grid.
src/components/WCDataVis/WCDataVis.stories.tsx Adds Storybook demos for wcdatavis wrapper usage.
src/components/WCDataVis/setup.ts Sets global window.jQuery/$ required by wcdatavis plugins.
src/components/WCDataVis/index.ts Public re-export surface for WCDataVis (currently mismatched vs implementation).
src/components/DataVisNITRO/DataVisNITRO.tsx Implements datavis (NITRO) wrapper grid using DataGrid/TableRenderer over a wcdatavis view.
src/components/DataVisNITRO/index.ts Public re-export surface for DataVis NITRO components/types.
src/components/DataVisNITRO/DataVisNITRO.stories.tsx Adds Storybook demos for DataVis NITRO wrapper usage.
.storybook/public/sample-data.json Adds sample dataset consumed by the new stories.
.storybook/preview-head.html Adds Font Awesome CSS inclusion for wcdatavis icons (currently via /node_modules).
.storybook/main.ts Tweaks Vite/esbuild JSX settings for Storybook.
package.json Adds datavis, wcdatavis, and font-awesome dependencies.
pnpm-lock.yaml Locks new dependencies and transitive deps for pnpm.
package-lock.json Updates npm lockfile to reflect the dependency graph as well.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 18, 2026

Deploying ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 18f2a05
Status: ✅  Deploy successful!
Preview URL: https://efb176f1.ui-6d0.pages.dev
Branch Preview URL: https://feature-datavis2.ui-6d0.pages.dev

View logs

Copilot AI review requested due to automatic review settings March 18, 2026 20:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 16 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot AI review requested due to automatic review settings March 18, 2026 20:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 16 changed files in this pull request and generated 8 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@tvenable-mie tvenable-mie marked this pull request as ready for review March 23, 2026 13:51
Copilot AI review requested due to automatic review settings March 23, 2026 13:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 16 changed files in this pull request and generated 5 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 16 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 25, 2026 21:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated 7 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 25, 2026 21:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated 8 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 25, 2026 21:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@garrity-miepub garrity-miepub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running this branch locally and wcdatavis runs perfectly after a pnpm install, but datavis nitro is throwing an error.

vite-app.js:31 SyntaxError: The requested module '/node_modules/.pnpm/numeral@2.0.6/node_modules/numeral/numeral.js?v=13e61733' does not provide an export named 'default' (at types.js:8:8)

Claudes 2 cents:

Image

@tvenable-mie
Copy link
Contributor Author

@garrity-miepub The dumb thing is, that same file is in DataVis NITRO and WC DataVis, and both run in Vite just fine, and the latter runs in Storybook just fine. But that's exactly the error I was dealing with all day yesterday. GPT 5.4 couldn't come up with a solution, and Opus 4.6 made all the changes in main.ts — after which it started working for me. I am suspicious that there are some caching causing troubles, because I have seen this a couple weeks ago and it resolved itself. I'll try a clean checkout and see if it works.

@tvenable-mie
Copy link
Contributor Author

GitHub Action build process is now encountering errors that I don't get on the command line in a clean checkout.

Copilot AI review requested due to automatic review settings March 26, 2026 14:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 26, 2026 14:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tvenable-mie
Copy link
Contributor Author

GitHub Action build process is now encountering errors that I don't get on the command line in a clean checkout.

Turns out it was caused by resolve.preserveSymlinks in the Vite config. Didn't change anything for me locally but it fixed the CI build. I love modern development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants