-
Notifications
You must be signed in to change notification settings - Fork 4
Add 'Email All' feature for users #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cmyers-mieweb
wants to merge
1
commit into
main
Choose a base branch
from
cmyers_issue305
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+145
−2
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -154,8 +154,68 @@ Medical Informatics Engineering`, | |
| await transporter.sendMail(mailOptions); | ||
| } | ||
|
|
||
| /** | ||
| * Escape HTML special characters to prevent injection in email HTML body | ||
| */ | ||
| function escapeHtml(str) { | ||
| return String(str) | ||
| .replace(/&/g, '&') | ||
| .replace(/</g, '<') | ||
| .replace(/>/g, '>') | ||
| .replace(/"/g, '"') | ||
| .replace(/'/g, '''); | ||
| } | ||
|
|
||
| /** | ||
| * Send a bulk email to multiple recipients (one message per recipient). | ||
| * Returns { sent, failed } where failed is an array of { to, error }. | ||
| * | ||
| * @param {string[]} recipients - List of recipient email addresses | ||
| * @param {string} subject - Email subject | ||
| * @param {string} message - Plain-text message body | ||
| */ | ||
| async function sendBulkEmail(recipients, subject, message) { | ||
| const settings = await Setting.getMultiple(['smtp_noreply_address']); | ||
| const from = settings.smtp_noreply_address || 'noreply@localhost'; | ||
|
|
||
| const transporter = await createTransport(); | ||
|
|
||
| // Convert plain-text body to safe HTML (preserve line breaks) | ||
| const htmlBody = escapeHtml(message).replace(/\r?\n/g, '<br>'); | ||
| const html = ` | ||
| <div style="font-family: Arial, sans-serif; max-width: 600px; margin: 0 auto;"> | ||
| <div style="color: #333; font-size: 14px; line-height: 1.5;">${htmlBody}</div> | ||
| <hr style="margin: 30px 0; border: none; border-top: 1px solid #eee;"> | ||
| <p style="color: #333; font-size: 14px;"> | ||
| <strong>Medical Informatics Engineering</strong> | ||
| </p> | ||
| </div> | ||
| `; | ||
|
|
||
| const sent = []; | ||
| const failed = []; | ||
|
|
||
| for (const to of recipients) { | ||
| try { | ||
| await transporter.sendMail({ | ||
| from, | ||
| to, | ||
| subject, | ||
| text: message, | ||
| html | ||
| }); | ||
| sent.push(to); | ||
| } catch (error) { | ||
| failed.push({ to, error: error.message }); | ||
| } | ||
| } | ||
|
Comment on lines
+198
to
+211
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we do a single email with BCC instead of looping? |
||
|
|
||
| return { sent, failed }; | ||
| } | ||
|
|
||
| module.exports = { | ||
| createTransport, | ||
| sendPasswordResetEmail, | ||
| sendInviteEmail | ||
| sendInviteEmail, | ||
| sendBulkEmail | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this fallback. If smtp_noreply_address is not set this should throw up instead.