fix(renderer): use --mieweb-font-sans token instead of hardcoded Titillium Web#39
Open
garrity-miepub wants to merge 2 commits into
Open
fix(renderer): use --mieweb-font-sans token instead of hardcoded Titillium Web#39garrity-miepub wants to merge 2 commits into
garrity-miepub wants to merge 2 commits into
Conversation
Remove Google Fonts @import for Titillium Web and replace hardcoded font-family with var(--mieweb-font-sans, 'Nunito') fallback chain. This allows consuming apps that load @mieweb/ui brand CSS to have the esheet components inherit the brand font, while standalone usage falls back to Nunito and system fonts.
1200313 to
c8fcf19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Google Fonts @import for Titillium Web and replace hardcoded font-family with var(--mieweb-font-sans, 'Nunito') fallback chain.
This allows consuming apps that load @mieweb/ui brand CSS to have the esheet components inherit the brand font, while standalone usage falls back to Nunito and system fonts.