Tests

[anishapant21]

Test Infrastructure

• Testing Pyramid Structure: Organized tests into unit, integration, and e2e
• Centralized Test Data: Created test/data/ directory with JSON/SQL files for all backends
• Data Loading Utilities: Built dataLoader.js and dbSeeder.js for consistent test data
• CI/CD Integration: Added GitHub Actions workflows for automated testing

Test Coverage

• Unit Tests: Core utilities (ldapUtils, filterUtils, errorUtils), LdapEngine, provider interfaces
• Integration Tests: SQL, MongoDB, Proxmox auth/directory providers with real backends
• E2E Tests: Full SSSD client authentication with Docker Compose setup

Test Organization

• Modular Structure: Separate npm package tests vs server tests
• Fixtures & Mocks: Reusable mock providers and test data
• Backend-Specific: Dedicated test suites for each backend (SQL, MongoDB, Proxmox)

# Run all tests
npm test

# Run by workspace
npm test -w npm        # Core package tests
npm test -w server     # Server tests

# Run specific backends
cd server
npm run test:integration -- auth/sql.auth.test.js
npm run test:integration -- directory/mongodb.directory.test.js

# Coverage report
npm run test:coverage -w npm
npm run test:coverage -w server

[Copilot]

Pull request overview

This PR adds comprehensive test infrastructure for the LDAP gateway project, implementing unit tests, integration tests, and SSSD integration tests. The changes include Jest configuration, test utilities, mock providers, and extensive test coverage for authentication, directory backends, and security features.

Key Changes

• Added Jest test framework configuration for both npm core package and server
• Created test utilities (TestServer, LdapTestClient, dbSeeder, mockLogger)
• Implemented unit tests for utilities, interfaces, and LdapEngine
• Added integration tests for SQL, MongoDB, and Proxmox backends
• Added SSSD integration tests with Docker Compose setup

Reviewed changes

Copilot reviewed 43 out of 44 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
npm/jest.config.js	Jest configuration for core package with coverage thresholds
npm/package.json	Added Jest dependencies and test scripts
npm/test/unit/utils/*.test.js	Unit tests for ldapUtils, filterUtils, errorUtils
npm/test/unit/interfaces/*.test.js	Unit tests for AuthProvider and DirectoryProvider
npm/test/unit/LdapEngine.test.js	Unit tests for LDAP engine lifecycle
npm/test/fixtures/*.js	Mock providers and shared test data fixtures
server/jest.config.js	Jest configuration for server integration tests
server/package.json	Added Jest and moved sequelize/sqlite to devDependencies
server/test/setup.js	Global test setup for server integration tests
server/test/utils/*.js	Test utilities (TestServer, LdapTestClient, dbSeeder, mockLogger)
server/test/fixtures/testData.js	Shared test data for integration tests
server/test/integration/auth/*.test.js	Auth backend integration tests (SQL, MongoDB, Proxmox)
server/test/integration/directory/*.test.js	Directory backend integration tests
server/test/integration/engine/*.test.js	Engine-level integration tests
server/test/integration/security/*.test.js	TLS policy and security tests
server/test/integration-sssd/*	SSSD integration test setup with Docker
server/utils/ldapUtils.js	Updated defaults for mail and surname fields
server/backends/proxmox.*.js	Added enabled/expire field support
server/db/drivers/mongoDb.js	Added connection checks and field normalization
npm/src/utils/ldapUtils.js	Support for both mail/email fields and login_shell
npm/src/utils/filterUtils.js	Fixed cn= filter handling for groups
npm/src/LdapEngine.js	Added cn filtering in mixed search requests
.github/workflows/ci.yml	Added MongoDB service and SSSD integration tests

[runleveldev]

This is big so I'm reviewing it at a very high level here:

Starting here, only the boxed test sounds worthwhile IMO, the rest test implementation details which may change.

I'm not sure any of these tests are worth it, they all seem like implementation details

Same here, these are all implementation details most of which are enforced by Node and not worth testing anyways

I actually like most of the following tests, but the boxed 2 I want to change the API contract on. The directory provider MUST provide uid and gid numbers to this function or we should consider it an error.

Again I don't think these are worth testing, they are mostly implementation details that may be subject to change.

These seem fine but I would like to see the LDAP filter being used in the test output personally.

These look good:

The boxed test here seems oddly specific. What's it really testing for?

Why are these "mocked"? We should at the very least be doing a REAL test against SQLite but preferably also dockerized mysql and postgresql databases.

These look fine, I will need to do a deeper dive into the test harness to ensure they're testing things correctly. I also thought we weren't using the expired field at all

I was running a mongodb in Docker similar to how the PR shows. The directory tests are passing

But all auth tests failed with the same error

    thrown: "Exceeded timeout of 30000 ms for a hook.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      44 |   };
      45 |
    > 46 |   beforeAll(async () => {
         |   ^
      47 |     // Check if MongoDB is available
      48 |     const testClient = new MongoClient(mongoConfig.uri, { serverSelectionTimeoutMS: 2000 });
      49 |     try {

      at test/integration/auth/mongodb.auth.test.js:46:3
      at Object.<anonymous> (test/integration/auth/mongodb.auth.test.js:30:1)