Skip to content

Fix: Return HTTP 404 for missing users instead of HTTP 500 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mw-middleware-labs-sandbox wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Return HTTP 404 for missing users instead of HTTP 500 #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions flask/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
)
)

from flask import Flask, render_template, request, jsonify
from flask import Flask, render_template, request, jsonify, abort
import logging
import os
from datetime import datetime
Expand Down Expand Up @@ -60,10 +60,10 @@ def generate_exception():
@app.route('/user/<username>')
def user_profile(username):
print(f"User profile requested for {username}")
test = user_data[username]
if not test:
raise
return jsonify({"message": f"Profile for {username}", "data": test})
if username not in user_data:
abort(404, description=f"User '{username}' not found")
user = user_data[username]
return jsonify({"message": f"Profile for {username}", "data": user})

@app.route('/process', methods=['POST'])
def process_user_data():
Expand Down Expand Up @@ -154,4 +154,4 @@ def user_stats(username):
})

if __name__ == '__main__':
app.run('0.0.0.0', 8010)
app.run('0.0.0.0', 8010)