Fix: Handle missing users gracefully in /user/<username> endpoint#39
Open
mw-middleware-labs-sandbox[bot] wants to merge 1 commit into
Open
Fix: Handle missing users gracefully in /user/<username> endpoint#39mw-middleware-labs-sandbox[bot] wants to merge 1 commit into
mw-middleware-labs-sandbox[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
user_profilefunction raises aKeyErrorwhen a non-existent user is requested, resulting in a 500 Internal Server Error instead of a proper 404 Not Found response.Root Cause
Direct dictionary access
user_data[username]at line 63 throws KeyError when the username doesn't exist in the dictionary.Solution
.get()method for safe lookupImpact
Testing
GET /user/user1→ 200 OK with profile dataGET /user/user7→ 404 Not Found with error messageFixes issue identified in APM trace:
KeyError: "User 'user7' not found"OpsAI Context
Open OpsAI Chat: Open Chat
Created By
Name: Sanjay
Email:
sanjay+sandbox@middleware.io