Skip to content

Conversation

@unnoq
Copy link
Member

@unnoq unnoq commented Jan 22, 2026

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.


Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @unnoq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant architectural upgrade by implementing an experimental version 2 (v2) builder across the client, contract, and server packages. This new builder provides a more structured and extensible framework for defining and implementing RPC procedures. It focuses on enhancing error handling with a dedicated ORPCError class, introducing a flexible meta-data and plugin system for procedure definitions, and integrating robust middleware support for server-side logic. The changes aim to improve type safety, modularity, and developer experience, particularly in complex environments with multiple dependency graphs.

Highlights

  • New v2 Builder Architecture: A comprehensive experimental version 2 (v2) builder has been introduced across the client, contract, and server packages. This new architecture provides a more modular and type-safe approach to defining RPC procedures.
  • Enhanced Error Handling: A dedicated ORPCError class and associated utilities are now available in the client package. This includes standardized error definitions, status codes, and a mechanism to handle instanceof checks robustly across different JavaScript environments, such as Next.js.
  • Flexible Meta-data and Plugin System: The contract package now features a flexible meta-data and plugin system. This allows for extensible procedure definitions and dynamic modification of metadata, enhancing the customizability of RPC contracts.
  • Robust Middleware Support: The server-side builder has been equipped with robust middleware capabilities. Developers can now chain logic, modify context, and process input/output at various stages of a procedure's execution, leading to more organized and reusable server logic.
  • Lazy Loading for Routers: A Lazy utility has been introduced for server-side routers, enabling asynchronous loading of router definitions. This feature can significantly improve application startup performance by deferring the loading of non-critical router components.
  • Improved Type Safety and Developer Experience: Extensive use of TypeScript interfaces and generics throughout the new v2 modules aims to provide a highly type-safe and intuitive developer experience for defining and implementing RPC services, reducing common errors and improving code maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 22, 2026

More templates

@orpc/ai-sdk

npm i https://pkg.pr.new/@orpc/ai-sdk@1382

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@1382

@orpc/client

npm i https://pkg.pr.new/@orpc/client@1382

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@1382

@orpc/experimental-durable-iterator

npm i https://pkg.pr.new/@orpc/experimental-durable-iterator@1382

@orpc/hey-api

npm i https://pkg.pr.new/@orpc/hey-api@1382

@orpc/interop

npm i https://pkg.pr.new/@orpc/interop@1382

@orpc/json-schema

npm i https://pkg.pr.new/@orpc/json-schema@1382

@orpc/nest

npm i https://pkg.pr.new/@orpc/nest@1382

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@1382

@orpc/openapi-client

npm i https://pkg.pr.new/@orpc/openapi-client@1382

@orpc/otel

npm i https://pkg.pr.new/@orpc/otel@1382

@orpc/experimental-pino

npm i https://pkg.pr.new/@orpc/experimental-pino@1382

@orpc/experimental-publisher

npm i https://pkg.pr.new/@orpc/experimental-publisher@1382

@orpc/experimental-publisher-durable-object

npm i https://pkg.pr.new/@orpc/experimental-publisher-durable-object@1382

@orpc/experimental-ratelimit

npm i https://pkg.pr.new/@orpc/experimental-ratelimit@1382

@orpc/react

npm i https://pkg.pr.new/@orpc/react@1382

@orpc/react-query

npm i https://pkg.pr.new/@orpc/react-query@1382

@orpc/experimental-react-swr

npm i https://pkg.pr.new/@orpc/experimental-react-swr@1382

@orpc/server

npm i https://pkg.pr.new/@orpc/server@1382

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@1382

@orpc/solid-query

npm i https://pkg.pr.new/@orpc/solid-query@1382

@orpc/standard-server

npm i https://pkg.pr.new/@orpc/standard-server@1382

@orpc/standard-server-aws-lambda

npm i https://pkg.pr.new/@orpc/standard-server-aws-lambda@1382

@orpc/standard-server-fastify

npm i https://pkg.pr.new/@orpc/standard-server-fastify@1382

@orpc/standard-server-fetch

npm i https://pkg.pr.new/@orpc/standard-server-fetch@1382

@orpc/standard-server-node

npm i https://pkg.pr.new/@orpc/standard-server-node@1382

@orpc/standard-server-peer

npm i https://pkg.pr.new/@orpc/standard-server-peer@1382

@orpc/svelte-query

npm i https://pkg.pr.new/@orpc/svelte-query@1382

@orpc/tanstack-query

npm i https://pkg.pr.new/@orpc/tanstack-query@1382

@orpc/trpc

npm i https://pkg.pr.new/@orpc/trpc@1382

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@1382

@orpc/vue-colada

npm i https://pkg.pr.new/@orpc/vue-colada@1382

@orpc/vue-query

npm i https://pkg.pr.new/@orpc/vue-query@1382

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@1382

commit: f1db6f3

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new experimental v2 builder, which is a significant feature addition. The changes span across multiple packages, adding a lot of new files for the v2 implementation. The new builder is designed with a fluent, type-safe API, leveraging advanced TypeScript features. The overall structure is well-thought-out. I've identified a couple of critical bugs in the implementation, along with some opportunities for improving type safety and reducing code duplication. My detailed feedback is in the comments below.

@unnoq unnoq closed this Jan 22, 2026
@unnoq
Copy link
Member Author

unnoq commented Jan 23, 2026

ffff

@unnoq
Copy link
Member Author

unnoq commented Jan 23, 2026

fff

@unnoq unnoq reopened this Jan 23, 2026
@unnoq unnoq closed this Jan 23, 2026
@middleapi middleapi deleted a comment from gemini-code-assist bot Jan 23, 2026
@middleapi middleapi deleted a comment from gemini-code-assist bot Jan 23, 2026
@middleapi middleapi deleted a comment from gemini-code-assist bot Jan 23, 2026
@middleapi middleapi deleted a comment from gemini-code-assist bot Jan 23, 2026
@middleapi middleapi deleted a comment from gemini-code-assist bot Jan 23, 2026
@middleapi middleapi deleted a comment from gemini-code-assist bot Jan 23, 2026
@unnoq unnoq deleted the feat/v2-builder branch January 23, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant