Skip to content

fix(tui): genericize image paste tooltip copy #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
middleDuckAi wants to merge 1 commit into
base: upstream-main-20260324
Choose a base branch
from
Draft

fix(tui): genericize image paste tooltip copy #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions codex-rs/tui/src/tooltips.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,4 +408,12 @@ content = "This is a test announcement"
parse_announcement_tip_toml(toml)
);
}

#[test]
fn clipboard_tooltip_does_not_hardcode_a_shortcut_label() {
assert!(TOOLTIPS.iter().any(|tooltip| {
*tooltip == "Paste an image from your clipboard to attach it to your next message."
}));
assert!(!TOOLTIPS.iter().any(|tooltip| tooltip.contains("Ctrl+V")));
}
}
2 changes: 1 addition & 1 deletion codex-rs/tui/tooltips.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ You can run any shell command from Codex using `!` (e.g. `!ls`)
Type / to open the command popup; Tab autocompletes slash commands.
When the composer is empty, press Esc to step back and edit your last message; Enter confirms.
Press Tab to queue a message when a task is running; otherwise it sends immediately (except `!`).
Paste an image with Ctrl+V to attach it to your next message.
Paste an image from your clipboard to attach it to your next message.
You can resume a previous conversation by running `codex resume`
8 changes: 8 additions & 0 deletions codex-rs/tui_app_server/src/tooltips.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,4 +408,12 @@ content = "This is a test announcement"
parse_announcement_tip_toml(toml)
);
}

#[test]
fn clipboard_tooltip_does_not_hardcode_a_shortcut_label() {
assert!(TOOLTIPS.iter().any(|tooltip| {
*tooltip == "Paste an image from your clipboard to attach it to your next message."
}));
assert!(!TOOLTIPS.iter().any(|tooltip| tooltip.contains("Ctrl+V")));
}
}
2 changes: 1 addition & 1 deletion codex-rs/tui_app_server/tooltips.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ You can run any shell command from Codex using `!` (e.g. `!ls`)
Type / to open the command popup; Tab autocompletes slash commands.
When the composer is empty, press Esc to step back and edit your last message; Enter confirms.
Press Tab to queue a message when a task is running; otherwise it sends immediately (except `!`).
Paste an image with Ctrl+V to attach it to your next message.
Paste an image from your clipboard to attach it to your next message.
You can resume a previous conversation by running `codex resume`
Loading