Skip to content

fix(exec): return non-zero when shell command fails#7

Draft
middleDuckAi wants to merge 4 commits into
upstream-main-20260324from
middleDuck/codex-15536-codex-exec-exits-0-even-when
Draft

fix(exec): return non-zero when shell command fails#7
middleDuckAi wants to merge 4 commits into
upstream-main-20260324from
middleDuck/codex-15536-codex-exec-exits-0-even-when

Conversation

@middleDuckAi
Copy link
Copy Markdown
Owner

@middleDuckAi middleDuckAi commented Mar 24, 2026

Summary

  • mark codex exec as failed when the active task receives ExecCommandEnd with Failed or Declined
  • keep the change scoped to the existing exec-session failure accounting
  • add a regression test proving a false shell command returns exit code 1

Why

  • the exec rollout can currently exit 0 even when the shell command itself finished non-zero

Testing

  • CARGO_TARGET_DIR=/tmp/codex-target-15536 cargo test -p codex-exec exits_non_zero_when_shell_command_finishes_failed -- --nocapture
  • just fix -p codex-exec
  • CARGO_TARGET_DIR=/tmp/codex-target-15536 cargo test -p codex-exec

jif-oai and others added 4 commits March 24, 2026 11:01
Add a `list_agents` for multi-agent v2, optionally path based

This return the task and status of each agent in the matched path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants