Merged
Conversation
baywet
reviewed
Jan 21, 2022
Member
baywet
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround on this one. One suggestion.
- Introduce base request adapter - Fix IUploadSession interface to use List instead of IEnumerable - Configure telemetry handler.
7f19d51 to
c815e17
Compare
baywet
suggested changes
Jan 24, 2022
Member
baywet
left a comment
There was a problem hiding this comment.
thanks for taking in the changes, one last thing.
…ionHandling Date, Time and Timepan serialization handling
baywet
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR :-
BaseRequestAdapterto enable passing of custom options to setup graphClient and easy configuration/creation of aIRequestAdapterinstance that works well with graph.GraphClientOptionsfor dependencies like graph cliNextExpectedRangesproperty type inIUploadSessionfromIEnumerabletoListas Kiota generates collection properties with theListtype.Microsoft Reviewers: Open in CodeFlow