ci: fix php generation #1401
Merged
ci: fix php generation #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinbarron
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PHP generation started to fail on October 3rd. Essentially, CI stopped escaping the double backslash 'Microsoft\Graph\Generated' which resulted in invalid namespace declarations. This should never have worked as the single quotes are for literals. The change in behavior is associated with the change from Bash to PowerShell:
https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator/pull/1380/files#diff-d0c85e8f27acaaab4d2c68d4d9f230af5aa626a859134a8cb097e5884de01289L93
It still shouldn't make a difference since Bash should still treat
'Microsoft\\Graph\\Generated'as a literal. I checked that the behavior change didn't happen in Kiota... it didn't as far as I can tell. Not worth more investigation since this shouldn't have worked in the first place.Microsoft Reviewers: Open in CodeFlow