-
Notifications
You must be signed in to change notification settings - Fork 74
ci: fix broken OpenAPI generation #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes OpenAPI generation that was broken in the previous dev merge to main. The changes enable OpenAPI files to be checked into the repository and introduce PR creation for reviewing OpenAPI changes before they are committed.
Key changes:
- Enhanced git-push-cleanmetadata.ps1 script to support PR creation workflow
- Added comprehensive logging and status checks throughout the process
- Implemented PR creation for OpenAPI files in the capture-openapi.yml pipeline
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/git-push-cleanmetadata.ps1 | Enhanced with PR creation support, improved logging, and better error handling |
| scripts/create-pull-request.ps1 | Fixed variable declaration order issue |
| .azure-pipelines/generation-templates/capture-openapi.yml | Added PR creation workflow and improved display names for clarity |
| .azure-pipelines/generation-templates/capture-metadata.yml | Updated to explicitly set CreatePR=False for CSDL metadata |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…crosoftgraph/MSGraph-SDK-Code-Generator into mmainer/fix-broken-generation
|
We have successful OpenAPI changes pushed and PRs opened: We have an approval gate for OCE to review OpenAPI before we generate SDKs. See build 201145. |
Summary
We broke OpenAPI generation with our last dev merge to main.
The changes in this PR include:
Microsoft Reviewers: Open in CodeFlow