Skip database tables with no export files#1210
Open
rlillyrfy wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents DuckDB table creation from crashing when an export produces no matching JSON files (commonly due to Graph permission/role restrictions), allowing the database-build phase to continue instead of aborting.
Changes:
- Added a pre-check in
New-EntraTableto detect when$FilePathmatches zero files. - Logs a warning and skips table creation when no matching export files are found.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+26
to
+29
| if (-not $matchingFiles) { | ||
| Write-PSFMessage "Skipping table $TableName because no files matched the pattern $FilePath" -Level Warning -Tag DB | ||
| return | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+25
to
+29
| $matchingFiles = Get-ChildItem -Path $FilePath -File -ErrorAction SilentlyContinue | Select-Object -First 1 | ||
| if (-not $matchingFiles) { | ||
| Write-PSFMessage "Skipping table $TableName because no files matched the pattern $FilePath" -Level Warning -Tag DB | ||
| return | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash in
New-EntraTablewhen processing exports with no matching files.When Graph API role restrictions prevent certain exports (e.g.,
User,ServicePrincipalSignIn), the table creation step fails with "No files found that match the pattern" because DuckDB cannot create a table from an empty file set.Changes
New-EntraTableto skip table creation when no export JSON files match the expected patternTesting