uniform minimumLicense requirements naming#1172
Open
Mynster9361 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the MinimumLicense metadata value for the Azure Front Door Premium-related assessment so that the generated ZeroTrustAssessmentReport.json uses a single consistent identifier for that license.
Changes:
- Renames the
MinimumLicensevalue in Test ID26884fromAzure_Front_Door_PremiumtoAzure_FrontDoor_Premium.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently after running the assessment if you want to parse the json file "ZeroTrustAssessmentReport.json" and want to look at minimum licenses requirements a hinderance i see is the diffrent naming schemes for the same topic example:
Azure_Front_Door_Premium
Azure_FrontDoor_Premium
2 different naming schemes for Azure FrontDoor Premium license.
I am adding an output of the diffrent categories below to show how it looks before this pr:
$t.Tests.TestMinimumLicense | select -Unique | sort
Advanced Message Encryption add-on
Azure Application Gateway Standard SKU
Azure Standard SKU
Azure WAF
Azure WAF on Azure Front Door Premium SKU
Azure_Application_Gateway_WAF
Azure_Firewall_Basic
Azure_Firewall_Premium
Azure_Firewall_Standard
Azure_Front_Door_Premium
Azure_FrontDoor_Premium
Azure_FrontDoor_Standard
Azure_WAF
DDoS_IP_Protection
DDoS_Network_Protection
Entra_Premium_Internet_Access
Entra_Premium_Private_Access
EXCHANGE_S_ENTERPRISE
Free
Governance
Intune
Microsoft 365 E3
Microsoft 365 E5
MIP_P1
P1
P2
Workload
AAD_PREMIUM
AAD_PREMIUM_P2