fix: category with naming mismatches to reduce duplicate categories in diffrent naming variants#1171
Open
Mynster9361 wants to merge 3 commits into
Open
fix: category with naming mismatches to reduce duplicate categories in diffrent naming variants#1171Mynster9361 wants to merge 3 commits into
Mynster9361 wants to merge 3 commits into
Conversation
…n diffrent naming variants
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes [ZtTest()] Category metadata values across several PowerShell assessment tests to reduce duplicate categories caused by inconsistent naming (e.g., hyphenated vs. title case, singular vs. plural).
Changes:
- Normalizes Sensitivity Labels categories to
Sensitivity Labels(removing variants likesensitivity-labelsandSensitivity Labels Configuration). - Normalizes device-related categories from
DevicestoDevice. - Aligns a few remaining category name variants (e.g.,
Rights Management Service→Rights Management Service (RMS),Applications management→Application management).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/powershell/tests/Test-Assessment.35024.ps1 | Aligns category to the existing Rights Management Service (RMS) naming. |
| src/powershell/tests/Test-Assessment.35015.ps1 | Changes category from sensitivity-labels to Sensitivity Labels. |
| src/powershell/tests/Test-Assessment.35013.ps1 | Changes category to Sensitivity Labels (but leaves header note category text outdated). |
| src/powershell/tests/Test-Assessment.35012.ps1 | Changes category to Sensitivity Labels (but leaves header note category text outdated). |
| src/powershell/tests/Test-Assessment.35003.ps1 | Changes category from sensitivity-labels to Sensitivity Labels. |
| src/powershell/tests/Test-Assessment.21955.ps1 | Changes category from Devices to Device. |
| src/powershell/tests/Test-Assessment.21954.ps1 | Changes category from Devices to Device. |
| src/powershell/tests/Test-Assessment.21953.ps1 | Changes category from Devices to Device. |
| src/powershell/tests/Test-Assessment.21886.ps1 | Changes category from Applications management to Application management. |
| src/powershell/tests/Test-Assessment.21837.ps1 | Changes category from Devices to Device. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently after running the assessment if you wnt to parse the json file "ZeroTrustAssessmentReport.json" and want to look at categories a hinderance i see is the diffrent naming schemes for the same topic example:
Sensitivity Labels
Sensitivity Labels Configuration
sensitivity-labels
3 different naming schemes for Sensitivity Labels.
I am adding an output of the diffrent categories below to show how it looks before this pr:
$t.Tests.TestCategory | select -Unique | sort
Access control
Access control; Credential management
Advanced Classification
Advanced Label Features
Application management
Application Proxy
Applications management
Azure Network Security
Credential management
Credential management, Privileged access
Data
Data Loss Prevention (DLP)
Data Security Posture Management
Device
Devices
Encryption
Entra
External collaboration
External Identities
Global Secure Access
Hybrid infrastructure
Identity
Identity governance
Information Protection
Label Policy Configuration
Microsoft Purview Message Encryption
Monitoring
Network
Network security
Private Access
Privileged access
Rights Management Service
Rights Management Service (RMS)
Role management
Sensitivity Labels
Sensitivity Labels Configuration
sensitivity-labels
SharePoint Online
Tenant