Skip to content

Move public doc-hidden Type trait into windows_core::imp#4413

Closed
Copilot wants to merge 4 commits into
masterfrom
copilot/move-type-to-imp-module
Closed

Move public doc-hidden Type trait into windows_core::imp#4413
Copilot wants to merge 4 commits into
masterfrom
copilot/move-type-to-imp-module

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026 •
edited
Loading

  • Move Type trait from windows_core crate root into hidden windows_core::imp module
  • Update windows-bindgen to emit windows_core::imp::Type
  • Regenerate bindings and update Windows-only fixture/sample bindings
  • Fix Windows-only test crates (noexcept, ref_params, collection_interop) and implement tests to use imp::Type
  • Fix rustfmt ordering in windows_core::lib.rs re-exports

Copilot AI linked an issue May 15, 2026 that may be closed by this pull request
windows-core has a public doc-hidden trait called Type #3699
Open
Copilot AI changed the title [WIP] Move public doc-hidden trait Type to windows_core::imp module Move public doc-hidden Type trait into windows_core::imp May 15, 2026
Copilot AI requested a review from kennykerr May 15, 2026 05:57
@kennykerr kennykerr requested a review from Copilot May 15, 2026 13:01
Copilot AI reviewed May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@kennykerr kennykerr marked this pull request as ready for review May 15, 2026 13:01
@kennykerr
Copy link
Copy Markdown
Collaborator

kennykerr commented May 15, 2026

@copilot ignore everything under crates/libs/windows and review everything else

@kennykerr
Copy link
Copy Markdown
Collaborator

kennykerr commented May 29, 2026

Will revisit later.

@kennykerr kennykerr closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kennykerr kennykerr Awaiting requested review from kennykerr

Assignees

@kennykerr kennykerr

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

windows-core has a public doc-hidden trait called Type

3 participants

@kennykerr