Fix Create on GitHub in Issue Reporter after extension bisect#314616
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix Create on GitHub in Issue Reporter after extension bisect#314616yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The bisect "Report Issue & Continue" path opened the Issue Reporter and then immediately reloaded the main window. The Issue Reporter lives in an auxiliary window whose services are owned by the main window, so the reload orphaned those services and made the Create on GitHub button (and other "show" buttons) silently no-op. Skip the trailing host reload when the user opted to report. Bisect state is still reset so the bad extension stays identified, and the user can manually reload to re-enable other temporarily disabled extensions once they finish filing the issue. Fixes microsoft#248339
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the extension bisect completion flow to avoid reloading the main workbench window when the user chooses “Report Issue & Continue”, because the Issue Reporter runs in an auxiliary window that depends on main-window services (and a reload can orphan those services, breaking “Create on GitHub” / “show” actions).
Changes:
- Skip the trailing
hostService.reload()when the user selects the report path, to keep the main window (and its services) alive while the Issue Reporter is open. - Keep clearing bisect state via
bisectService.reset()and continue to honor the “Keep this extension disabled” choice.
Comment on lines
+325
to
+327
| await bisectService.reset(); | ||
| await commandService.executeCommand('workbench.action.openIssueReporter', done.id); | ||
| return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After extension bisect identifies a bad extension, choosing "Report Issue & Continue" opens the Issue Reporter and then immediately reloads the main window. The Issue Reporter lives in an auxiliary window whose services are owned by the main window, so reloading orphans those service references and makes the "Create on GitHub" button (and other "show" buttons) silently do nothing.
This change skips the trailing
hostService.reload()only on the report path. Bisect storage is still reset and the chosen "keep this extension disabled" choice is honored. The user can reload the window themselves once they're done with the issue report.Fixes #248339
Test plan
Extension Bisect: Start Extension Bisectand complete bisect to identify a bad extension.showbuttons all work.