Skip to content

Git - guard against undefined paths in parseGitChangesRaw (#287615) #314614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yogeshwaran-c wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Git - guard against undefined paths in parseGitChangesRaw (#287615) #314614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions extensions/git/src/git.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,6 +1138,9 @@ function parseGitChangesRaw(repositoryRoot: string, raw: string): DiffChange[] {
// Parse --raw output
const [, , , , change] = segment.split(' ');
const filePath = segments[index++];
if (!filePath) {
break;
}
Comment on lines 1138 to +1143
const originalUri = Uri.file(path.isAbsolute(filePath) ? filePath : path.join(repositoryRoot, filePath));

let uri = originalUri;
Expand Down Expand Up @@ -1185,6 +1188,9 @@ function parseGitChangesRaw(repositoryRoot: string, raw: string): DiffChange[] {
index++;

const renamePath = segments[index++];
if (!renamePath) {
break;
}
numstatPath = path.isAbsolute(renamePath) ? renamePath : path.join(repositoryRoot, renamePath);
} else {
numstatPath = path.isAbsolute(filePath) ? filePath : path.join(repositoryRoot, filePath);
Comment on lines +1192 to 1196
Expand Down
Loading