agent-host: restore selected model in picker#314613
Merged
roblourens merged 6 commits intoMay 6, 2026
Merged
Conversation
Use session state as the source of truth for existing agent host sessions, while keeping resource-scheme-scoped storage as the view-state fallback for new untitled sessions. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agents window’s Agent Host model picker to prefer the model already associated with the active session (when present), and to treat persisted picker selection as untitled-session view state rather than as a default for existing sessions.
Changes:
- Add scheme-scoped storage keys and a small resolver to determine which model should be displayed for a given session.
- Update the model picker initialization logic to use session state first, and only consult stored picker state for untitled sessions.
- Add targeted regression unit tests for storage key construction and model resolution behavior.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/chat/browser/agentHost/agentHostModelPicker.ts | Implements scheme-scoped storage keys and updates model resolution/initialization logic for the agent-host model picker. |
| src/vs/sessions/contrib/chat/test/browser/agentHostModelPicker.test.ts | Adds regression tests for storage key generation and model resolution behavior. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
…located-at-vsckb-implement-file-7d1b70c6 # Conflicts: # src/vs/sessions/contrib/chat/browser/agentHost/agentHostModelPicker.ts
…located-at-vsckb-implement-file-7d1b70c6 (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…located-at-vsckb-implement-file-7d1b70c6
…located-at-vsckb-implement-file-7d1b70c6
Recompute Agent Host model picker state when the active session status changes so storage fallback is only used while a session is untitled. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benvillalobos
approved these changes
May 6, 2026
roblourens
deleted the
agents/use-the-skill-located-at-vsckb-implement-file-7d1b70c6
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
(Written by Copilot)